rimashah25 commented on code in PR #6544:
URL: https://github.com/apache/trafficcontrol/pull/6544#discussion_r848645100
##########
lib/go-tc/servers.go:
##########
@@ -700,6 +700,44 @@ type CommonServerProperties struct {
XMPPPasswd *string `json:"xmppPasswd"
db:"xmpp_passwd"`
}
+type CommonServerPropertiesV40 struct {
Review Comment:
I like option `a` since it is simple and easy to understand. Also, I am
removing two fields and changing one. Or you can look at it as removing 3
fields and adding one. So CommonServerProperties() will have to undergo change
and then there will be more code changes to support v3/v2.
@rawlinp: If the right thing to do is option `b`, I will change the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
