rob05c opened a new pull request, #6756: URL: https://github.com/apache/trafficcontrol/pull/6756
Fix t3c nil pointer crash on TO API fallback Also fixes fallback with cookie login Unfortunately, as before, these things can't be tested without an Integration Test Framework that supports multiple TO versions. Which we'd really like, but it's also a lot of work to add. I manually tested against both a TO with the latest API (4.x), and a TO only serving the previous (3.x), both succeeded and generated config correctly, previous fell back as expected for both initial username and subsequent cookie login, latest did not fall back. ## Which Traffic Control components are affected by this PR? - Traffic Control Cache Config (`t3c`, formerly ORT) ## What is the best way to verify this PR? Run t3c, verify config is generated correctly against a latest TO, verify config is generated correctly against a TO not serving the latest major API. ## If this is a bugfix, which Traffic Control versions contained the bug? Bug, but not in a release. ## PR submission checklist - ~[x] This PR has tests~ framework doesn't exist, would be a large undertaking to add <!-- If not, please delete this text and explain why this PR does not need tests. --> - ~[x] This PR has documentation~ no interface change <!-- If not, please delete this text and explain why this PR does not need documentation. --> - ~[x] This PR has a CHANGELOG.md entry~ not in a release <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
