rob05c commented on code in PR #6724:
URL: https://github.com/apache/trafficcontrol/pull/6724#discussion_r852184862
##########
tc-health-client/tmagent/tmagent.go:
##########
@@ -49,6 +49,14 @@ const (
StrategiesFile = "strategies.yaml"
)
+// this global is used to auto select the
+// proper ATS traffic_ctl command to use
+// when querying host status. for ATS
+// version 10 and greater this will remain
+// at 0. For ATS version 9, this will be
+// auto updated to 1
+var traffic_ctl_index = 0
Review Comment:
Nitpick: Go symbols should be consistentCased, i.e. `var trafficCtlIndex =
0`.
https://go.dev/doc/effective_go#mixed-caps
It'd also be ideal to avoid global variables, and pass it locally instead.
But for what's effectively a singleton in a small app, not a huge deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
