rob05c opened a new pull request, #6764: URL: https://github.com/apache/trafficcontrol/pull/6764
Refactors the t3c client login, cookie cache, and fallback. We saw some more edge cases around fallback and cookie usage ending up with nil dereferences. This breaks it into smaller functions and reduces the nested if-else blocks, hopefully making it easier to work with and less likely to have issues. ## Which Traffic Control components are affected by this PR? - Traffic Control Cache Config (`t3c`, formerly ORT) ## What is the best way to verify this PR? Run t3c, verify cookie usage in logs, verify fallback behavior against new and old TO. ## If this is a bugfix, which Traffic Control versions contained the bug? Not in a release ## PR submission checklist - ~[x] This PR has tests~ existing tests cover cookie behavior, and t3c Integration Tests don't support multiple TO versions <!-- If not, please delete this text and explain why this PR does not need tests. --> - ~[x] This PR has documentation~ no docs, no interface change <!-- If not, please delete this text and explain why this PR does not need documentation. --> - ~[x] This PR has a CHANGELOG.md entry~ no interface change, any potential bugs aren't in a release <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
