zrhoffman commented on code in PR #6711:
URL: https://github.com/apache/trafficcontrol/pull/6711#discussion_r854968174
##########
traffic_ops/traffic_ops_golang/deliveryservice/eligible.go:
##########
@@ -107,7 +108,8 @@ func GetServersEligible(w http.ResponseWriter, r
*http.Request) {
return
}
v3server := tc.DSServer{}
- v3server.DSServerBase =
srv.DSServerBaseV4.ToDSServerBase(&routerHostName, &routerPort)
+ pid, pdesc := dbhelpers.GetProfileIDDesc(inf.Tx.Tx,
*v3server.Profile)
Review Comment:
`v3server.Profile` is `nil` at this point, so `*v3server.Profile` panics
##########
traffic_ops/traffic_ops_golang/deliveryservice/eligible.go:
##########
@@ -82,7 +82,8 @@ func GetServersEligible(w http.ResponseWriter, r
*http.Request) {
return
}
v11server := tc.DSServerV11{}
- v11server.DSServerBase =
srv.DSServerBaseV4.ToDSServerBase(&routerHostName, &routerPort)
+ pid, pdesc := dbhelpers.GetProfileIDDesc(inf.Tx.Tx,
*v11server.Profile)
Review Comment:
`v11server.Profile` is `nil` at this point, so `*v11server.Profile` panics
##########
CHANGELOG.md:
##########
@@ -18,6 +18,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
- Added functionality for login to provide a Bearer token and for that token
to be later used for authorization.
- [Traffic Ops | Traffic Go Clients | T3C] Add additional timestamp fields to
server for queuing and dequeueing config and revalidate updates.
- Added layered profile feature to 4.0 for `GET` servers/, `POST` servers/,
`PUT` servers/{id} and `DELETE` servers/{id}.
+- Added layered profile feature to 4.0 for `GET`
deliveryservices/{id}/servers/.
Review Comment:
and `GET /deliveryservices/{id}/servers/eligible`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
