rimashah25 commented on code in PR #6593:
URL: https://github.com/apache/trafficcontrol/pull/6593#discussion_r856314725
##########
lib/go-tc/servers.go:
##########
@@ -87,8 +87,33 @@ type ServerDetailV30 struct {
// ServerDetailV40 is the details for a server for API v4.
type ServerDetailV40 struct {
- ServerDetail
- ServerInterfaces []ServerInterfaceInfoV40 `json:"interfaces"`
+ CacheGroup *string `json:"cachegroup"
db:"cachegroup"`
+ CDNName *string `json:"cdnName"
db:"cdn_name"`
+ DeliveryServiceIDs []int64
`json:"deliveryservices,omitempty"`
+ DomainName *string `json:"domainName"
db:"domain_name"`
+ GUID *string `json:"guid" db:"guid"`
+ HardwareInfo map[string]string `json:"hardwareInfo"`
Review Comment:
Sure but to note: in the unit test, there is a specific check for this field:
```
if len(actualSrvs[0].HardwareInfo) != 3 {
t.Fatalf("servers.read expected len(actualSrvs[0].HardwareInfo)
== 3, actual = %v", len(actualSrvs[0].HardwareInfo))
}
```
If `Hardware Info` was removed in APIv1, then I am assuming this check is ok
to remove too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
