ocket8888 commented on code in PR #6593:
URL: https://github.com/apache/trafficcontrol/pull/6593#discussion_r856509305


##########
lib/go-tc/servers.go:
##########
@@ -87,8 +87,33 @@ type ServerDetailV30 struct {
 
 // ServerDetailV40 is the details for a server for API v4.
 type ServerDetailV40 struct {
-       ServerDetail
-       ServerInterfaces []ServerInterfaceInfoV40 `json:"interfaces"`
+       CacheGroup         *string                  `json:"cachegroup" 
db:"cachegroup"`
+       CDNName            *string                  `json:"cdnName" 
db:"cdn_name"`
+       DeliveryServiceIDs []int64                  
`json:"deliveryservices,omitempty"`
+       DomainName         *string                  `json:"domainName" 
db:"domain_name"`
+       GUID               *string                  `json:"guid" db:"guid"`
+       HardwareInfo       map[string]string        `json:"hardwareInfo"`

Review Comment:
   actually that complicates things. I was only always seeing null because my 
TO instance isn't years old. If you created HWInfo structures back in APIv1, 
then APIv3's `servers/details` was still showing them. So that's probably 
something we'd need to take to the mailing list. For all I know that's the 
entire reason we still have this route.
   
   So probably don't worry about that in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to