rob05c commented on code in PR #6708:
URL: https://github.com/apache/trafficcontrol/pull/6708#discussion_r858911195


##########
lib/go-atscfg/parentdotconfig.go:
##########
@@ -839,7 +865,11 @@ func getParentDSParams(ds DeliveryService, 
profileParentConfigParams map[string]
        if !ok {
                return params, warnings
        }
-
+       if val, ok := dsParams[StrategyConfigUsePeering]; ok {
+               if val == "true" {

Review Comment:
   Nitpick: this should probably ignore the value, and consider it always true 
if the Param exists, to be consistent with the behavior of other boolean params



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to