ocket8888 commented on code in PR #6762:
URL: https://github.com/apache/trafficcontrol/pull/6762#discussion_r871775149
##########
traffic_ops/testing/api/v4/cdnnotifications_test.go:
##########
@@ -53,26 +80,21 @@ func CreateTestCDNNotifications(t *testing.T) {
var opts client.RequestOptions
for _, cdn := range testData.CDNs {
resp, _, err :=
TOSession.CreateCDNNotification(tc.CDNNotificationRequest{CDN: cdn.Name,
Notification: "test notification: " + cdn.Name}, opts)
Review Comment:
Hm. That does sound better, but it's not replicating the behavior of the
existing tests, so I wouldn't ask you to do that. It just bothers me that
something labeled a "refactor" changes the code's behavior and not merely its
structure.
I'll leave it up to you. If you really think it's best to run fewer tests
then that's fine. If you think it adds value to make it do the two tests you
just described, then do it. But if that doesn't sound worthwhile to you, don't
waste time on it and I'll just approve this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
