ocket8888 commented on code in PR #6827:
URL: https://github.com/apache/trafficcontrol/pull/6827#discussion_r878633934
##########
traffic_ops/traffic_ops_golang/deliveryservice/health.go:
##########
@@ -115,29 +118,26 @@ func getMonitorHealth(tx *sql.Tx, ds
tc.DeliveryServiceName, monitorFQDNs []stri
}
// addHealth adds the given cache states to the given data and totals, and
returns the new data and totals
-func addHealth(ds tc.DeliveryServiceName, data
map[tc.CacheGroupName]tc.HealthDataCacheGroup, totalOnline uint64, totalOffline
uint64, crStates tc.CRStates, crConfig tc.CRConfig)
(map[tc.CacheGroupName]tc.HealthDataCacheGroup, uint64, uint64) {
+func addHealth(ds tc.DeliveryServiceName, data
map[tc.CacheGroupName]tc.HealthDataCacheGroup, totalOnline uint64, totalOffline
uint64, crStates tc.CRStates, crConfig tc.CRConfig) (error,
map[tc.CacheGroupName]tc.HealthDataCacheGroup, uint64, uint64) {
Review Comment:
nit: errors should be the last return value when there are multiple
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
