ocket8888 commented on code in PR #6753:
URL: https://github.com/apache/trafficcontrol/pull/6753#discussion_r879814365
##########
experimental/traffic-portal/src/app/shared/tp-header/tp-header.component.scss:
##########
@@ -53,6 +57,10 @@ nav {
}
}
+a.mat-menu-item {
+ text-transform: uppercase;
Review Comment:
Ah, `mat-button` wouldn't do it for you anyway:
> According to the Material design spec button text has to be capitalized,
however we have opted not to capitalize buttons automatically via
`text-transform: uppercase`, because it can cause issues in certain locales. It
is also worth noting that using ALL CAPS in the text itself causes issues for
screen-readers, which will read the text character-by-character. We leave the
decision of how to approach this to the consuming app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
