ocket8888 opened a new pull request, #6981:
URL: https://github.com/apache/trafficcontrol/pull/6981

   This obscures sensitive text fields. `<textarea>` fields display blurred 
text except on hover or while being interacted with (e.g. holding down tap on 
mobile), and simple `<input/>` fields are `input[type="password"]`s by default, 
with a button that changes them to `input[type="text]`s (and back again).
   
   Partially addresses #6953.
   
   The fields obscured are:
   - server ILO passwords
   - Delivery Service SSL private keys
   - Delivery Service "Header Rewrite" rule fields
   - Delivery Service "Raw Remap Text" field.
   
   This also adds a re-usable component to the experimental Traffic Portal v2 
that provides the `<input>` `type` attribute swapping as an Angular Material 
Forms-compatible form control value accessor, and uses it in place of the 
inline solution currently used on the login page as well as for the server 
details page's ILO Password field.
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   Make sure the provided unit tests for the new TPv2 component have sufficient 
coverage and pass. Actual functionality is minimally impacted, so existing e2e 
tests should all still pass.
   
   ## PR submission checklist
   - [x] This PR has tests
   - [x] This PR has JSDoc documentation
   - [x] This PR has a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to