rob05c commented on code in PR #6991:
URL: https://github.com/apache/trafficcontrol/pull/6991#discussion_r933640574
##########
cache-config/t3c-apply/torequest/torequest.go:
##########
@@ -1169,17 +1175,25 @@ func (r *TrafficOpsReq) UpdateTrafficOps(syncdsUpdate
*UpdateStatus) error {
// TODO: The boolean flags/representation can be removed after ATC
(v7.0+)
if !r.Cfg.ReportOnly && !r.Cfg.NoUnsetUpdateFlag {
+ start := time.Now()
+ apply := []string{}
+ var b bool
Review Comment:
Another nitpick: the scope of this variable is a bit too long for a single
character. Variable name lengths should correspond to their scope.
Single-letter vars are ok for just a couple lines, but for a dozen or so
like here, something more descriptive like "updateFlagVal" would be easier to
read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
