ocket8888 commented on code in PR #6996:
URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r936072015
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -131,6 +131,9 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
* 4.x API
*/
+ // Assign Multiple Server Capabilities
+ {Version: api.Version{Major: 4, Minor: 1}, Method:
http.MethodPut, Path: `multiple_server_capabilities/{id}$`, Handler:
server.AssignMultipleServerCapabilities, RequiredPrivLevel:
auth.PrivLevelOperations, RequiredPermissions: []string{"SERVER:UPDATE",
"SERVER:CREATE", "SERVER:READ", "SERVER-CAPABILITY:READ"}, Authenticated:
Authenticated, Middlewares: nil, ID: 40792419258},
Review Comment:
Do you need to be able to create servers to use this route? Currently,
assigning a single Capability to a single server does not require
`SERVER:CREATE`, and it would make sense to me for the required Permissions to
be the same for the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
