zrhoffman commented on code in PR #7003:
URL: https://github.com/apache/trafficcontrol/pull/7003#discussion_r938061786


##########
cache-config/testing/docker/trafficserver/Dockerfile:
##########
@@ -63,10 +63,12 @@ RUN if [[ ${OS_VERSION%%.*} -ge 8 ]]; then \
                        curl \
                        gcc-toolset-9 \
                        gcc-toolset-9-runtime \
+                       geoip \
                        jansson \
                        jansson-devel \
                        libmaxminddb \
-                       libmaxminddb-devel); \
+                       libmaxminddb-devel \
+                       libuuid ); \

Review Comment:
   `rockylinux:8`, `centos:7`, and `centos:8` all include the `libuuid` 
package. Is specifying it needed?
   
   ```shell
   [zrhoffman@computer ~]$ for image in rockylinux:8 centos:{7,8}; do docker 
run --rm "$image" rpm -q libuuid; done
   libuuid-2.32.1-35.el8.x86_64
   libuuid-2.23.2-65.el7.x86_64
   libuuid-2.32.1-27.el8.x86_64
   ```



##########
infrastructure/cdn-in-a-box/cache/Dockerfile:
##########
@@ -60,6 +60,7 @@ RUN dnf -y install epel-release && \
         libmaxminddb            \
         libtool-ltdl            \
         libunwind               \
+        libuuid                 \

Review Comment:
   `rockylinux:8`, `centos:7`, and `centos:8` all include the `libuuid` 
package. Is specifying it needed?
   
   ```shell
   [zrhoffman@computer ~]$ for image in rockylinux:8 centos:{7,8}; do docker 
run --rm "$image" rpm -q libuuid; done
   libuuid-2.32.1-35.el8.x86_64
   libuuid-2.23.2-65.el7.x86_64
   libuuid-2.32.1-27.el8.x86_64
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to