ocket8888 commented on code in PR #6996:
URL: https://github.com/apache/trafficcontrol/pull/6996#discussion_r940394232
##########
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##########
@@ -516,13 +516,14 @@ func AssignMultipleServerCapabilities(w
http.ResponseWriter, r *http.Request) {
FROM inserted
) AS returned(server_capability)`
- err = tx.QueryRow(mscQuery, pq.Array(msc.ServerCapability),
msc.ServerID).Scan(pq.Array(&multipleServerCapabilities))
+ err = tx.QueryRow(mscQuery, pq.Array(msc.ServerCapabilities),
msc.ServerID).Scan(pq.Array(&multipleServerCapabilities))
if err != nil {
useErr, sysErr, statusCode := api.ParseDBError(err)
api.HandleErr(w, r, tx, statusCode, useErr, sysErr)
return
}
- alerts := tc.CreateAlerts(tc.SuccessLevel, fmt.Sprintf("Multiple Server
Capabilities assigned to a server:%d", msc.ServerID))
+ msc.ServerCapabilities = multipleServerCapabilities
+ alerts := tc.CreateAlerts(tc.SuccessLevel, fmt.Sprintf("Multiple Server
Capabilities assigned to a server"))
Review Comment:
`fmt.Sprintf` is unnecessary when its only argument is a constant string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
