srijeet0406 commented on PR #7023:
URL: https://github.com/apache/trafficcontrol/pull/7023#issuecomment-1226609989
> The `ServerV4` type alias in `lib/go-tc/servers.go` still says that the
latest version of a server is `ServerV40`. This means that other API endpoints
that show servers - e.g. `/deliveryservices/{{ID}}/servers/eligible` etc. - all
now have different representations of a server than `/servers`. This is, in my
opinion, bad. An API object should have exactly one representation.
I've updated the `ServerV4` to point to `ServerV41` now. However, if you hit
the other endpoints, for example, `/deliveryservices/{{ID}}/servers/eligible`,
you'd still get a server representation without the `ASN` field. That field is
only added for the `GET` routes of `/servers`. Because there is not 4.1
equivalent route for the other endpoints (for example,
`/deliveryservices/{{ID}}/servers/eligible`), they still return the version 4.0
representation of the server object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
