ocket8888 commented on code in PR #7042:
URL: https://github.com/apache/trafficcontrol/pull/7042#discussion_r959826133
##########
traffic_ops/traffic_ops_golang/server/put_status.go:
##########
@@ -121,7 +121,7 @@ func UpdateStatusHandler(w http.ResponseWriter, r
*http.Request) {
return
}
- if *status.Name == tc.CacheStatusAdminDown.String() || *status.Name ==
tc.CacheStatusOffline.String() {
+ if *status.Name != tc.CacheStatusOnline.String() && *status.Name !=
tc.CacheStatusReported.String() {
Review Comment:
Server statuses should not be mutable. It's one of a million places where we
hijacked a concept to provide arbitrary informative tagging, which is better
provided by [actual tags](https://github.com/apache/trafficcontrol/pull/4819).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
