srijeet0406 commented on code in PR #7063:
URL: https://github.com/apache/trafficcontrol/pull/7063#discussion_r967546168
##########
docs/source/api/v4/servers.rst:
##########
@@ -40,7 +40,7 @@ Request Structure
| cachegroupName | no | Return only those servers within the
:term:`Cache Group` that has this :ref:`cache-group-name` |
Review Comment:
Looks like the alignment here is a little off.
##########
traffic_ops/v5-client/README.md:
##########
@@ -0,0 +1,53 @@
+# Traffic Ops Go Client
+
Review Comment:
Shouldn't this have the `Unstable` section that you removed from the
v4-client/ README.md?
##########
docs/source/api/v4/deliveryserviceserver.rst:
##########
@@ -58,7 +58,7 @@ Response Structure
------------------
Unlike most API endpoints, this will return a JSON response body containing
both a "response" object as well as other, top-level fields (besides the
optional "alerts" field). For this reason, this section contains a "response"
key, which normally is implicit.
-.. seealso:: :ref:`to-api-response-structure`
+.. seealso:: :ref:`to-api-v4-response-structure`
Review Comment:
Don't you need to define this label at the top of the page that it points to?
##########
traffic_ops/testing/api/utils/utils.go:
##########
@@ -98,13 +99,11 @@ func CreateV4Session(t *testing.T, TrafficOpsURL string,
username string, passwo
return userSession
}
-// V3TestCase is the type of the V3TestData struct.
-// Uses nested map to represent the method being tested and the test's
description.
-type V3TestCase map[string]map[string]V3TestData
-
-// V4TestCase is the type of the V4TestData struct.
-// Uses nested map to represent the method being tested and the test's
description.
-type V4TestCase map[string]map[string]V4TestData
+func CreateV5Session(t *testing.T, TrafficOpsURL, username, password string,
toReqTimeout int) *v5client.Session {
+ userSession, _, err := v5client.LoginWithAgent(TrafficOpsURL, username,
password, true, "to-api-v4-client-tests", false,
time.Second*time.Duration(toReqTimeout))
Review Comment:
Should be "to-api-v5-client-tests"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
