ocket8888 commented on code in PR #7073:
URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r976670398
##########
lib/go-tc/deliveryservice_servers.go:
##########
@@ -189,21 +189,33 @@ type DSServerResponseV30 struct {
// DSServerV4 contains information for a V4.x Delivery Service Server.
type DSServerV4 struct {
+ DSServerV40
+ ASNs []int64 `json:"asns"`
+}
+
+// DSServerV40 contains information for a V4.0 Delivery Service Server.
+type DSServerV40 struct {
DSServerBaseV4
ServerInterfaces *[]ServerInterfaceInfoV40 `json:"interfaces"
db:"interfaces"`
}
// DSServerResponseV40 is the type of a response from Traffic Ops to a request
// for servers assigned to a Delivery Service - in API version 4.0.
type DSServerResponseV40 struct {
+ Response []DSServerV40 `json:"response"`
+ Alerts
+}
+
+// for servers assigned to a Delivery Service - in API version 4.0.
Review Comment:
GoDoc comment should start with an optional article and the name of the
documented symbol, and be a complete sentence.
##########
docs/source/api/v5/deliveryservices_id_servers.rst:
##########
@@ -40,6 +40,9 @@ Request Structure
Response Structure
------------------
+:asns: The :abbr:`ASN (Autonomous System Number)` associated with
the cachegroups of the current server.
+
+ .. versionadded:: 4.1
Review Comment:
This is native to APIv5, you don't need to let people know what minor
version of a previous API added it
##########
docs/source/api/v5/deliveryservices_id_servers_eligible.rst:
##########
@@ -46,6 +46,9 @@ Request Structure
Response Structure
------------------
+:asns: The :abbr:`ASN (Autonomous System Number)` associated with
the cachegroups of the current server.
+
+ .. versionadded:: 4.1
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
