ocket8888 commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r983879958
##########
traffic_portal/app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html:
##########
@@ -20,11 +20,12 @@
<div class="x_panel">
<div class="x_title">
<ol class="breadcrumb pull-left">
- <li><a href="#!/server-capabilities">Server Capabilities</a></li>
- <li><a
ng-href="#!/server-capabilities/{{serverCapability.name}}">{{::serverCapability.name}}</a></li>
+ <li><a ng-click="navigateToPath('/server-capabilities')">Server
Capabilities</a></li>
+ <li><a ng-click="navigateToPath('/server-capabilities/edit?name='
+ serverCapability.name)">{{::serverCapability.name}}</a></li>
Review Comment:
> a lot of pages (co-ordiantes, deliveryservice etc), which are referencing
breadcrumbs have ng-click.
Those pages are doing that wrong. They should also not be using click events
for navigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
