ocket8888 commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r983902839


##########
docs/source/overview/profiles_and_parameters.rst:
##########
@@ -497,7 +497,7 @@ For each Parameter with this Config File value on the same 
:ref:`Profile <profil
 
 .. _tm-related-cache-server-params:
 
-rascal.properties
+traffic_monitor.properties
 '''''''''''''''''

Review Comment:
   This title underline is now too short, needs to be expanded to match the new 
title length



##########
traffic_ops/traffic_ops_golang/server/servers.go:
##########
@@ -856,6 +856,12 @@ func getServers(h http.Header, params map[string]string, 
tx *sqlx.Tx, user *auth
 `
        }
 
+       if version.Major >= 5 {
+               if params["type"] == "RASCAL" {
+                       params["type"] = "TRAFFIC_MONITOR"
+               }
+       }
+

Review Comment:
   We shouldn't do this; you can still make server types, so someone could make 
their own RASCAL type and then never be able to filter on that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to