zrhoffman commented on code in PR #7109:
URL: https://github.com/apache/trafficcontrol/pull/7109#discussion_r989385185
##########
traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java:
##########
@@ -527,7 +527,7 @@ private static void primeZoneCache(final String domain,
final Name name, final L
}
}
final Zone zone = zc.get(newZoneKey); // cause
the zone to be loaded into the new cache
- if (tr.isDnssecZoneDiffingEnabled()) {
+ if (tr.isDnssecEnabled()) {
Review Comment:
Same here, this part can just be removed
##########
traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java:
##########
@@ -511,7 +511,7 @@ private static void primeZoneCache(final String domain,
final Name name, final L
generationTasks.add(() -> {
try {
final ZoneKey newZoneKey =
signatureManager.generateZoneKey(name, list);
- if (tr.isDnssecZoneDiffingEnabled() &&
domainsToZoneKeys.containsKey(domain)) {
Review Comment:
The RRSIG cache makes zone diffing obsolete, so you could just remove this
part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
