ocket8888 commented on code in PR #7118:
URL: https://github.com/apache/trafficcontrol/pull/7118#discussion_r992723542
##########
traffic_ops/traffic_ops_golang/deliveryservice/keys_test.go:
##########
@@ -2260,6 +2261,7 @@ func TestVerifyAndEncodeCertificateSelfSignedX509v1(t
*testing.T) {
certChain, certPrivateKey, unknownAuth, _, err :=
verifyCertKeyPair(SelfSignedX509v1Certificate, SelfSignedX509v1PrivateKey, "",
true)
if err != nil {
+ fmt.Println(err)
t.Fatalf("unexpected result: the x509v1 cert/key pair is valid
and should have passed validation")
Review Comment:
to print the error that occurred, it should be added to the `t.Fatalf` call
instead of printed directly to stdout with `fmt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
