zrhoffman opened a new pull request, #7142: URL: https://github.com/apache/trafficcontrol/pull/7142
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: Closes: #ISSUE Related: #ISSUE If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> This PR makes it so that when the CDN in a Box for Developers services create new files (from `npm ci`, building debug binaries, creating Traffic Router DBs, etc.), the files are owned by the user who owns the repository directory, rather than being owned by root. <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - CDN in a Box - for Developers ## What is the best way to verify this PR? <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> 1. Remove generated files and directories: ```shell rm -rf dev/traffic_router/db experimental/traffic-portal/node_modules traffic_monitor/__debug_bin traffic_ops/traffic_ops_golang/__debug_bin traffic_portal/node_modules ``` 2. Build the CDN in a Box for Developers: ```shell docker-compose build ``` 3. Start the Dev CiaB: ```shell docker-compose up ``` 4. Verify that the generated files and directories are owned by you ```shell ls -ld dev/traffic_router/db experimental/traffic-portal/node_modules traffic_monitor/__debug_bin traffic_ops/traffic_ops_golang/__debug_bin traffic_portal/node_modules ``` and verify that those all are owned by you ## PR submission checklist - [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. --> - [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
