rob05c commented on code in PR #7137:
URL: https://github.com/apache/trafficcontrol/pull/7137#discussion_r997370334
##########
lib/go-atscfg/parentdotconfig.go:
##########
@@ -383,258 +390,112 @@ func makeParentDotConfigData(
continue
}
- isMSO := ds.MultiSiteOrigin != nil && *ds.MultiSiteOrigin
+ // manufacture a topology for this DS.
Review Comment:
Mind putting this in a func? It's a pretty big block, and does a very
singular thing. IMO it'd make the code a lot easier to read and work with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
