zrhoffman commented on code in PR #7156:
URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1004982343
##########
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go:
##########
@@ -614,7 +614,7 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS
bool) ([]interface{}, er
for _, ds := range dses {
switch {
// NOTE: it's required to handle minor version cases in a
descending >= manner
- case version.Major >= 4 && version.Minor >= 1:
+ case version.Major > 4 || (version.Major == 4 && version.Minor
>= 1):
Review Comment:
This is fine, though `Version.GreaterThanOrEqualTo()` can be used now, too
https://github.com/apache/trafficcontrol/blob/6c532922e706481cb944820b8fa6af20cc3d11ee/traffic_ops/traffic_ops_golang/cdn/cdns.go#L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
