ocket8888 commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005063876
##########
traffic_ops/testing/api/v5/deliveryservice_request_comments_test.go:
##########
@@ -178,7 +178,9 @@ func CreateTestDeliveryServiceRequestComments(t *testing.T)
{
opts.QueryParameters.Set("xmlId", comment.XMLID)
resp, _, err := TOSession.GetDeliveryServiceRequests(opts)
assert.NoError(t, err, "Cannot get Delivery Service Request by
XMLID '%s': %v - alerts: %+v", comment.XMLID, err, resp.Alerts)
- assert.Equal(t, len(resp.Response), 1, "Found %d Delivery
Service request by XMLID '%s, expected exactly one", len(resp.Response),
comment.XMLID)
+ if !assert.Equal(t, len(resp.Response), 1, "Found %d Delivery
Service request by XMLID '%s, expected exactly one", len(resp.Response),
comment.XMLID) {
Review Comment:
Because although creation of the currently processed comment has failed (or
at best succeeded wrongly), other comments can still be created, which can help
narrow down what the problem was and/or find other problems by continuing to
run other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
