rob05c opened a new pull request, #7167: URL: https://github.com/apache/trafficcontrol/pull/7167
Moves the TO test setup to a shared library to remove duplication in the ORT/t3c integration tests, because that was easier than upgrading t3c tests to API v4, which was necessary to test multiple profiles. It turned out, moving the TO test data setup to a library was easier than fixing all the changes in v4. It's a lot of lines changes (3k duplicate lines removed), but there's no logic change in the tests, just moving and renaming things. More conveniences could be added, like moving the WithObjs helpers to the library and removing the wrappers. But it seemed better to keep this as small as possible; it's already huge. ## Which Traffic Control components are affected by this PR? - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Control Client Go ## What is the best way to verify this PR? Run tests. ## If this is a bugfix, which Traffic Control versions contained the bug? Not a bug fix. ## PR submission checklist - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - ~[x] This PR has documentation~ no docs, no interface change <!-- If not, please delete this text and explain why this PR does not need documentation. --> - ~[x] This PR has a CHANGELOG.md entry~ no changelog, no user interface change <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
