zrhoffman commented on code in PR #7180:
URL: https://github.com/apache/trafficcontrol/pull/7180#discussion_r1017012943


##########
dev/t3c/run.sh:
##########
@@ -20,6 +20,9 @@
 set -o errexit
 trap '[ $? -eq 0 ] && exit 0 || echo "Error on line ${LINENO} of ${0}"; exit 
1' EXIT
 
+cd $TC
+go mod vendor

Review Comment:
   `go mod vendor` removes all the contents of the `vendor` directory and 
re-adds them, so we shouldn't run `go mod vendor` unless it's actually needed.
   
   Everything in the `vendor` directory is tracked in git except for 
`vendor/golang.org/x`, so maybe only run `go mod vendor` if that directory 
doesn't exist?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to