ocket8888 commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1018500420
##########
traffic_ops/testing/api/v5/tc-fixtures.json:
##########
@@ -341,7 +341,7 @@
{
Review Comment:
it would seem not. The PR that added that field didn't add them to the
fixtures and the tests all pass fine. I believe that's abusing the fact that if
a field isn't found when unmarshaling, Go will just leave it as the "zero"
value of its type. It's not proper IMO, but it's also outside the scope of my
PR to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
