zrhoffman commented on code in PR #7192:
URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1024587976
##########
tc-health-client/tmagent/tmagent.go:
##########
@@ -656,7 +656,7 @@ func (pi *ParentInfo) GetTOData(cfg *config.Cfg) error {
if *sv.CDNName != cfg.CDNName {
continue
}
- if sv.Type == tc.MonitorTypeName && tc.CacheStatus(*sv.Status)
== tc.CacheStatusOnline {
+ if (sv.Type == tc.MonitorTypeName || sv.Type ==
tc.RascalTypeName) && tc.CacheStatus(*sv.Status) == tc.CacheStatusOnline {
Review Comment:
`|| sv.Type == tc.RascalTypeName` is not needed, since #7190 revert renaming
`RASCAL` to `TRAFFIC_MONITOR`.
##########
lib/go-tc/enum.go:
##########
@@ -143,6 +143,15 @@ const MonitorTypeName = "TRAFFIC_MONITOR"
// properly, and new code should not check this.
const MonitorProfilePrefix = "TRAFFIC_MONITOR"
+// RascalTypeName is the Name of the Type which must be assigned to a server
+// for it to be treated as a Traffic Monitor instance by ATC.
+//
+// "Rascal" is a legacy name for Traffic Monitor.
+//
+// Note that there is, in general, no guarantee that a Type with this name
+// exists in Traffic Ops at any given time.
+const RascalTypeName = "RASCAL"
+
Review Comment:
Since #7190 revert renaming `RASCAL` to `TRAFFIC_MONITOR`, this part is not
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
