zrhoffman commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025548842
##########
traffic_ops/testing/api/utils/utils.go:
##########
@@ -119,7 +130,7 @@ type V3TestData struct {
// V3TestDataT represents the data needed for testing the v3 api endpoints.
type V3TestDataT[B any] struct {
- EndpointId func() int
+ EndpointID func() int
Review Comment:
It's not just my personal opinion, it's the guidelines that our community
voted on. Under [*One pull request per
feature*](https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md#one-pull-request-per-feature):
> Like big functions, big pull requests are just hard to review. Make each
pull request as small as possible.
There's a reason we have that guideline, and it's for cases like these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
