ocket8888 opened a new pull request, #7227: URL: https://github.com/apache/trafficcontrol/pull/7227
I'm trying to add some typings to Traffic Portal things, but every PR that does that will need to add typings for JS libraries we use. So, this adds them in its own PR, to help keep the others cleaner. This doesn't add type imports to **every** place they are used, but it does some just because the PRs I cherry-picked originally modified some files that I had to touch anyway for other reasons in the full changeset for which they were originally written. This will help find bugs, and in some cases ease the transition of code from TPv1 into TPv2. <hr/> ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR? There should be no behavior change, so existing tests should all still pass. To check the typings, use a TypeScript compiler capable of static JavaScript analysis via JSDoc typings, or some editor/IDE with that functionality built in. ## PR submission checklist - [x] This PR uses existing tests - [x] This PR is documentation of a sort - [x] This PR doesn't need a CHANGELOG.md entry - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
