ocket8888 commented on code in PR #7233:
URL: https://github.com/apache/trafficcontrol/pull/7233#discussion_r1043799571
##########
docs/source/overview/profiles_and_parameters.rst:
##########
@@ -308,7 +308,7 @@ This configuration file is mainly generated based on the
assignments of :term:`c
ip_allow.config
'''''''''''''''
-This configuration file is mostly generated from various server data, but can
be affected by a Parameter that has a :ref:`parameter-name` of
"purge_allow_ip", which will cause the insertion of a line with
:file:`src_ip={VALUE} action=ip_allow method=ALL` where ``VALUE`` is the
Parameter's Value_. Additionally, Parameters with :ref:`Names <parameter-name>`
like :file:`coalesce_{masklen|number}_v{4|6}` cause Traffic Ops to generate
coalesced IP ranges in different ways. In the case that ``number`` was used,
the Parameter's Value_ sets the the maximum number of IP address that may be
coalesced into a single range. If ``masklen`` was used, the lines that are
generated are coalesced into :abbr:`CIDR (Classless Inter-Domain Routing)`
ranges using mask lengths determined by the Value_ of the parameter (using '4'
sets the mask length of IPv4 address coalescing while using '6' sets the mask
length to use when coalescing IPv6 addresses). This is not recommended, as the
default mask lengths al
low for maximum coalescence. Furthermore, if two Parameters on the same
:ref:`Profile <profiles>` assigned to a server having Config File values of
``ip_allow.config`` and :ref:`Names <parameter-name>` that are both
"coalesce_masklen_v4" but each has a different Value_, then the actual mask
length used to coalesce IPv4 addresses is undefined (but will be one of the
two). All forms of the "coalescence Parameters" have this problem.
+This configuration file is mostly generated from various server data, but can
be affected by a Parameter that has a :ref:`parameter-name` of
"purge_allow_ip", which will cause the insertion of a line with
:file:`src_ip={VALUE} action=ip_allow method=ALL` where ``VALUE`` is the
Parameter's Value_, to allow purge from multiple IPs use a comma separated list
in the Parameter's Value_. Additionally, Parameters with :ref:`Names
<parameter-name>` like :file:`coalesce_{masklen|number}_v{4|6}` cause Traffic
Ops to generate coalesced IP ranges in different ways. In the case that
``number`` was used, the Parameter's Value_ sets the the maximum number of IP
address that may be coalesced into a single range. If ``masklen`` was used, the
lines that are generated are coalesced into :abbr:`CIDR (Classless Inter-Domain
Routing)` ranges using mask lengths determined by the Value_ of the parameter
(using '4' sets the mask length of IPv4 address coalescing while using '6' sets
the mask length to use
when coalescing IPv6 addresses). This is not recommended, as the default mask
lengths allow for maximum coalescence. Furthermore, if two Parameters on the
same :ref:`Profile <profiles>` assigned to a server having Config File values
of ``ip_allow.config`` and :ref:`Names <parameter-name>` that are both
"coalesce_masklen_v4" but each has a different Value_, then the actual mask
length used to coalesce IPv4 addresses is undefined (but will be one of the
two). All forms of the "coalescence Parameters" have this problem.
Review Comment:
I think that's a run-on sentence. Should probably be "`... Parameter's
Value_. To ...`" rather than "`... Parameter's Value_, to ...`".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
