ocket8888 commented on code in PR #7120:
URL: https://github.com/apache/trafficcontrol/pull/7120#discussion_r1047683940


##########
docs/source/overview/delivery_services.rst:
##########
@@ -1087,27 +1087,31 @@ Each :term:`Parameter` directly corresponds to a field 
in a line of the :abbr:`A
        | algorithm                               | `round_robin`_              
                               | Sets the algorithm used to determine from 
which :term:`origin server` content will  |
        |                                         |                             
                               | be requested.                                  
                                     |
        
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
-       | max_simple_retries                      | `max_simple_retries`_       
                               | Sets a strict limit on the number of "simple 
retries" allowed before giving up      |
-       
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
-       | max_unavailable_server_retries          | 
`max_unavailable_server_retries`_                          | Sets a strict 
limit on the number of times the :term:`cache server` will attempt to |
-       |                                         |                             
                               | request content from an :term:`origin server` 
that has previously been considered   |
-       |                                         |                             
                               | "unavailable".                                 
                                     |
-       
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
        | parent_retry                            | `parent_retry`_             
                               | Sets whether the :term:`cache servers` will 
use "simple retries",                   |
-       |                                         |                             
                               | "unavailable server retries", or both.         
                                     |
+       |                                         |                             
                               | "unavailable server retries", or both.  
Deprecated (see below).                     |
        
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
        | simple_retry_response_codes             | **UNKNOWN**                 
                               | **UNKNOWN** - supposedly defines HTTP response 
codes from an :term:`origin server`  |
        |                                         |                             
                               | that necessitate a "simple retry".             
                                     |
        
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
+       | max_simple_retries                      | `max_simple_retries`_       
                               | Sets a strict limit on the number of "simple 
retries" allowed before giving up      |
+       
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
        | unavailable_server_retry_response_codes | 
`unavailable_server_retry_responses`_                      | Defines HTTP 
response codes from an :term:`origin server` that indicate it is       |
        |                                         |                             
                               | currently "unavailable".                       
                                     |
        
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
+       | max_unavailable_server_retries          | 
`max_unavailable_server_retries`_                          | Sets a strict 
limit on the number of times the :term:`cache server` will attempt to |
+       |                                         |                             
                               | request content from an :term:`origin server` 
that has previously been considered   |
+       |                                         |                             
                               | "unavailable".                                 
                                     |
+       
+-----------------------------------------+------------------------------------------------------------+-------------------------------------------------------------------------------------+
 
 The above :term:`Parameters` are supported for ``first``, ``inner`` and 
``last`` tiers by specifying prefixes ``first.``, ``inner.`` and ``last.``, 
applicable to both topology and non topology. This allows fine tuning of 
marking parents "down" and retry behavior inside a CDN.
 
 .. deprecated:: The ``mso.`` prefix is deprecated.  ``last.`` prefix should be 
preferred although no prefix can also be used.
 
-.. warning:: The `simple_retry_response_codes`` :term:`Parameter` has no 
apparent, possible use according to the :abbr:`ATS (Apache Traffic Server)` 
`parent.config documentation 
<https://docs.trafficserver.apache.org/en/9.1.x/admin-guide/files/parent.config.en.html>`_.
 Whether or not it has any effect - let alone the *intended* effect - is not 
known, and its use is therefore strongly discouraged.
+.. deprecated:: The parent_retry parameter is now inferred from the `simple 
retry` and `unavailable server retry` parameters.  To disable `simple retries` 
associate parameter ``max_simple_retries`` of ``0`` and 
``max_simple_retry_responses`` of ``""``.  Similarly "unavailable server 
retries" may also be disabled.

Review Comment:
   Oh, `last.parent_retry` isn't even in this file. That deprecation notice 
should be wherever the Parameter is documented. But it wouldn't surprise me if 
it wasn't at all outside of the quick-how-to, so if that's the case, just 
disregard that part of the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to