zrhoffman commented on code in PR #7272:
URL: https://github.com/apache/trafficcontrol/pull/7272#discussion_r1064973460
##########
traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/router/StatTrackerTest.java:
##########
@@ -38,6 +38,6 @@ public void testIncTally() {
track.setRouteType(StatTracker.Track.RouteType.DNS, "blah");
track.setResult(StatTracker.Track.ResultType.CZ);
tracker.saveTrack(track);
- assertEquals("expected czCount to be max integer value but got " +
tallies.getCzCount(), Integer.MAX_VALUE, tallies.getCzCount());
+ assertEquals("expected czCount to be max integer value but got " +
tallies.getCzCount(), Long.MAX_VALUE, tallies.getCzCount());
Review Comment:
Assertion message should be updated too 🙂
##########
CHANGELOG.md:
##########
@@ -36,6 +36,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7120](https://github.com/apache/trafficcontrol/pull/7120) *Docs* Update
t3c documentation regarding parent.config parent_retry.
### Fixed
+- [#7252](https://github.com/apache/trafficcontrol/issues/7252) *Traffic
Router* Fixed integer overflow for `czCount`.
Review Comment:
Maybe mention how it was fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
