rawlinp commented on PR #7274:
URL: https://github.com/apache/trafficcontrol/pull/7274#issuecomment-1379459891

   That might be problematic because after upgrading TO and snapshotting the 
CDN, all old versions of TM will fail to unmarshal the new monitoring.json due 
to it being a breaking change. Or, if you upgrade TMs first, they'd be 
expecting the new format and would also fail that way.
   
   I wonder if instead it would be possible for TO to "squash" the layered 
profiles into a single profile which is then used in the monitoring.json, which 
would allow the monitoring.json format to remain the same without any breaking 
changes?
   
   For instance, if a given server had the profiles A, B, and C, TO could just 
squash those into something like `"profile": "A+B+C"` (in the `trafficServers` 
object) and have the "squashed" profile like a normal one:
   ```
                {
                  "name": "A+B+C",
                  "parameters": {
                    "health.connection.timeout": 2000,
                    "health.polling.url": 
"http://${hostname}/_astats?application=&inf.name=${interface_name}";,
                    "health.threshold.availableBandwidthInKbps": ">1750000",
                    "health.threshold.loadavg": "60.0",
                    "health.threshold.queryTime": 1000,
                    "history.count": 30
                  },
                  "type": "EDGE"
                }
   ```
   in the monitoring.json?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to