ocket8888 commented on code in PR #7279: URL: https://github.com/apache/trafficcontrol/pull/7279#discussion_r1073848285
########## infrastructure/cdn-in-a-box/Makefile: ########## @@ -35,7 +41,8 @@ PKG_COMMAND := $(TC_DIR)/pkg PKG_FLAGS := -v -$(RHEL_VERSION) BUILD_SUFFIX := _build BUILD_NUMBER := $(shell git rev-list HEAD 2>/dev/null | wc -l | tr -d '[[:space:]]').$(shell git rev-parse --short=8 HEAD) -BUILD_ARCH := $(shell rpm --eval %_arch) +# no --rm on the docker command to speed up reuse for shell completion +BUILD_ARCH := $(shell docker run --name=ciab-get-$(BASE_IMAGE)-$(RHEL_VERSION)-arch $(BASE_IMAGE):$(RHEL_VERSION) rpm --eval %_arch) Review Comment: I just want to be on record saying that I think it's totally heinous that we need to launch a mini virtual machine just to determine part of a file name based on the CPU architecture of the host machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
