ocket8888 commented on code in PR #7295: URL: https://github.com/apache/trafficcontrol/pull/7295#discussion_r1084304992
########## CHANGELOG.md: ########## @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). ## [unreleased] ### Added +- *Traffic Portal* Added description and priority order for Layered Profile on server form. Review Comment: We're trying to make all of these have links now ########## traffic_portal/app/src/common/modules/form/server/form.server.tpl.html: ########## @@ -111,8 +111,18 @@ </div> <fieldset> - <legend>Profiles<button name="addProfileBtn" class="btn btn-primary right-button btn-xs" type="button" title="add a new profile to the server" ng-click="addProfile()"><i class="fa fa-plus"></i></button></legend> - <fieldset ng-repeat="profile in server.profileNames track by $index"> + <legend title="Layered Profiles for a given server."> Profiles + <button name="addProfileBtn" class="btn btn-primary right-button btn-xs" type="button" title="add new profile(s) to the server" ng-click="addProfile()"><i class="fa fa-plus"></i></button> + </legend> + <div class="helptext"> Review Comment: This `DIV` doesn't seem to be serving any purpose. It isn't displaying like other `.helptext` elements do - i.e. on hover - and it doesn't appear to be styled in any way so CSS isn't using it. It's just a container element with no semantic meaning, so it's not important to the document structure. So, if this isn't meant to be on-hover help text, I'd suggest removing the div so nobody seeing that thinks it's broken. If it *is* meant to be on-hover help text, then some work needs to be done to get that to display properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
