ocket8888 opened a new pull request, #7307:
URL: https://github.com/apache/trafficcontrol/pull/7307

   This PR hides the true value of a DS's `Active` property _everywhere_ across 
the Traffic Portal UI, whereas #7296 only did so for drop-down active 
selections in DS forms. Specifically, this missed two places where the true 
value was still visible:
   
   - Tables
   - DSR "Current/Previous Value" boxes
   
   ... and this PR hides it in both places (when `exposeInactive` isn't `true`).
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   Make a DS and a DSR where `Active` is PRIMED, then check in Traffic Portal 
and verify that in tables and the DSR comparison/comments view it displays as 
"INACTIVE" (or "Inactive", as appropriate). Then set `exposeInactive` to `true` 
in the Traffic Portal properties and observe that the actual value of PRIMED is 
used.
   
   ## PR submission checklist
   - [x] This PR doesn't need tests
   - [x] This PR doesn't need documentation
   - [x] This PR doesn't need a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to