ocket8888 commented on code in PR #7314:
URL: https://github.com/apache/trafficcontrol/pull/7314#discussion_r1091173483
##########
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html:
##########
@@ -350,17 +350,15 @@ <h3 ng-if="!open()">Previous Value</h3>
</label>
<div class="col-md-10 col-sm-10 col-xs-12">
<div class="checkbox-scroll-container">
- <div ng-repeat="capability in
requiredCapabilities">
+ <div ng-repeat="capability in
requiredCapabilities track by $index">
<input
- type="checkbox"
- id="capability"
- name="capability"
-
ng-model="selectedCapabilities[capability.name]"
-
ng-checked="selectedCapabilities[capability.name]"
+ type="checkbox"
+ id="capability-{{$index}}"
+ name="capability-{{$index}}"
+
ng-model="selectedCapabilities[capability.name]"
+
ng-checked="selectedCapabilities[capability.name]"
Review Comment:
You don't need a `<label>` for every `<input>`, but if it doesn't have one
it should have an `aria-label` attribute set. Probably just the name of the
Capability will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
