rimashah25 commented on code in PR #7362:
URL: https://github.com/apache/trafficcontrol/pull/7362#discussion_r1121978221
##########
experimental/traffic-portal/src/app/core/cache-groups/cache-group-table/cache-group-table.component.spec.ts:
##########
@@ -185,23 +185,7 @@ describe("CacheGroupTableComponent", () => {
expect(menuItem.href({...sampleCG, id:
5})).toBe("core/cache-groups/5");
});
it("doesn't allow selection of unimplemented context menu items", () =>
{
- let menuItem = component.contextMenuItems.find(i => i.name ===
"Manage ASNs");
- if (!menuItem) {
- return fail("'Manage ASNs' context menu item not
found");
- }
- if (!isAction(menuItem)) {
- return fail(`Invalid 'Manage ASNs' context menu item;
not an action: ${menuItem}`);
- }
- if (typeof(menuItem.disabled) !== "function") {
- return fail("'Manage ASNs' context menu item should be
disabled, but no disabled function is defined");
- }
- if (menuItem.multiRow) {
- expect(menuItem.disabled([sampleCG])).toBeTrue();
- } else {
- expect(menuItem.disabled(sampleCG)).toBeTrue();
- }
-
- menuItem = component.contextMenuItems.find(i => i.name ===
"Manage Servers");
Review Comment:
I thought I should have but wasn't sure.. thanks for confirming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
