ocket8888 commented on code in PR #7358:
URL: https://github.com/apache/trafficcontrol/pull/7358#discussion_r1122256871
##########
experimental/traffic-portal/src/app/core/statuses/status-details/status-details.module.ts:
##########
@@ -0,0 +1,36 @@
+import { NgModule } from '@angular/core';
+import { CommonModule } from '@angular/common';
+import { StatusDetailsComponent } from './status-details.component';
+import { RouterModule } from '@angular/router';
+import { ReactiveFormsModule } from '@angular/forms';
+import { MatFormFieldModule } from '@angular/material/form-field';
+import { MatInputModule } from '@angular/material/input';
+import {MatGridListModule} from '@angular/material/grid-list';
+import { MatCardModule } from '@angular/material/card';
+import { SharedModule } from 'src/app/shared/shared.module';
+import { MatButtonModule } from '@angular/material/button';
+
+const StatusDetailRouting = RouterModule.forChild([
+ {
+ path: '',
+ component: StatusDetailsComponent
+ }
+]);
+
+@NgModule({
+ declarations: [
+ StatusDetailsComponent
+ ],
+ imports: [
+ CommonModule,
+ StatusDetailRouting,
+ ReactiveFormsModule,
+ MatFormFieldModule,
+ MatInputModule,
+ MatGridListModule,
+ MatCardModule,
+ MatButtonModule,
+ SharedModule
+ ]
+})
+export class StatusDetailsModule { }
Review Comment:
I think that's pretty overkill, to make a different module for every single
view. At best, it's premature optimization, and at worst it's detrimental
because of increased loading times and significantly increased build times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
