serDrem commented on code in PR #7302:
URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1134690894
##########
traffic_monitor/datareq/crstate.go:
##########
@@ -109,11 +110,11 @@ func updateStatusSameIpServers(localStates
peer.CRStatesThreadsafe, toData todat
allIsAvailable := true
for partner, _ := range toDataC.SameIpServers[cache] {
if partnerState, ok :=
localStatesC.Caches[partner]; ok {
- // a partner host is reported but is
marked down for too high traffic or load
+ // a partner host is reported but is
marked down for exceeding a threshold
// this host also needs to be marked
down to divert all traffic for their
// common ip
if
strings.Contains(partnerState.Status, string(tc.CacheStatusReported)) &&
-
strings.Contains(partnerState.Status, "too high") {
+
strings.Contains(partnerState.Status, fmt.Sprint(health.TooHigh)) {
Review Comment:
more elegant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]