ocket8888 commented on code in PR #7429: URL: https://github.com/apache/trafficcontrol/pull/7429#discussion_r1170248298
########## infrastructure/ansible/roles/traffic_portal_v2/README.md: ########## @@ -0,0 +1,66 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> +Traffic_portal_v2 +========= + +At the primary user interface of Apache Traffic Control is the component Traffic PortaL which is installed with this role. + +Requirements +------------ + +* A valid RPM in an available yum repository. + +Role Variables +-------------- + +Refer to the defaults/main.yml for most information. + +tpv2_version: This is an optional string that can be provided to specify a particular version of Traffic Portal to install. It should be something like `3.0.0-10063.5db80eca.el7`. The absense of this variable entails automatically using the latest version available to yum at the time of initial installation. Review Comment: sp: absen<del>s</del>e -> absen<ins>c</ins>e ########## infrastructure/ansible/roles/traffic_portal_v2/README.md: ########## @@ -0,0 +1,66 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> +Traffic_portal_v2 +========= + +At the primary user interface of Apache Traffic Control is the component Traffic PortaL which is installed with this role. + +Requirements +------------ + +* A valid RPM in an available yum repository. + +Role Variables +-------------- + +Refer to the defaults/main.yml for most information. + +tpv2_version: This is an optional string that can be provided to specify a particular version of Traffic Portal to install. It should be something like `3.0.0-10063.5db80eca.el7`. The absense of this variable entails automatically using the latest version available to yum at the time of initial installation. + +tpv2_properties_template: An optional dictionary to merge into/atop the default traffic_portal_properties.json file + +additional_yum_repos: An optional list of additional yum repositories to enable specifically when installing this component. This could be used to enable non-production ready rpms in a separate repository and not supplying the specific RPM version to automatically use the latest available. Review Comment: Can you put these into an itemized (i.e. unordered) list? ########## infrastructure/ansible/roles/traffic_portal_v2/meta/main.yml: ########## @@ -0,0 +1,33 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +galaxy_info: + author: Jonathan Gray Review Comment: not that I think he cares, but I think this is a mis-attribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
