ocket8888 commented on code in PR #3:
URL:
https://github.com/apache/trafficcontrol-trafficops-types/pull/3#discussion_r1170575921
##########
src/server.ts:
##########
@@ -331,7 +335,11 @@ export interface RequestServer {
* @deprecated In the latest API version, a server's Profile is
identified
* only by name, not unique, integral identifier.
*/
- profileId: number;
+ profileId: number | null;
Review Comment:
same as above
##########
src/server.ts:
##########
@@ -510,10 +518,11 @@ export interface ServerDetails {
mgmtIpNetmask: string;
offlineReason: string;
physLocation: string;
- profile: string;
+ profile: string | null;
/** @deprecated This has been removed from the latest API version. */
- profileDesc: string;
+ profileDesc: string | null;
Review Comment:
these two properties have been removed, and will never be either `string` or
`null`
##########
src/server.ts:
##########
@@ -208,22 +208,26 @@ export interface ResponseServer {
*/
physLocationId: number;
/** The Profile used by the Server. */
- profile: string;
+ profile: string | null;
/**
* A description of the Profile used by the Server.
*
* @deprecated Future representations of Server objects will drop the
* Profile description entirely, as it's trivially deduced from Profile
* identity.
*/
- profileDesc: string;
+ profileDesc: string | null;
Review Comment:
same as above
##########
src/server.ts:
##########
@@ -208,22 +208,26 @@ export interface ResponseServer {
*/
physLocationId: number;
/** The Profile used by the Server. */
- profile: string;
+ profile: string | null;
Review Comment:
same as above
##########
src/server.ts:
##########
@@ -510,10 +518,11 @@ export interface ServerDetails {
mgmtIpNetmask: string;
offlineReason: string;
physLocation: string;
- profile: string;
+ profile: string | null;
/** @deprecated This has been removed from the latest API version. */
- profileDesc: string;
+ profileDesc: string | null;
/** @deprecated this has no known purpose, and you shouldn't invent
one. */
+ profileNames: Array<string>;
Review Comment:
this deprecation JSDoc comment belongs to the `rack` property
##########
src/server.ts:
##########
@@ -208,22 +208,26 @@ export interface ResponseServer {
*/
physLocationId: number;
/** The Profile used by the Server. */
- profile: string;
+ profile: string | null;
/**
* A description of the Profile used by the Server.
*
* @deprecated Future representations of Server objects will drop the
* Profile description entirely, as it's trivially deduced from Profile
* identity.
*/
- profileDesc: string;
+ profileDesc: string | null;
/**
* An integral, unique identifier for the Profile used by the Server.
*
* @deprecated In the latest API version, a server's Profile is
identified
* only by name, not unique, integral identifier.
*/
- profileId: number;
+ profileId: number | null;
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
