ocket8888 opened a new pull request, #7462: URL: https://github.com/apache/trafficcontrol/pull/7462
This adds some linting rules for templates in TPv2. Right now, it's spitting out a bunch of warnings, which might be disabled entirely in the future (each one has an accompanying rationale in the configuration file). It also makes the code compliant with the linting rules. The biggest change is just that all buttons now must have an explicit `type` attribute - even when using the implicit default `submit` type. That helps catch buttons that *shouldn't* be `submit` type, but also buttons incorrectly used as links etc. <hr/> ## Which Traffic Control components are affected by this PR? - Traffic Portal (experimental v2) ## What is the best way to verify this PR? Make sure the code passes the new linting rules (albeit with warnings) ## PR submission checklist - [x] This PR has tests - [x] This PR doesn't need documentation - [x] This PR doesn't need a CHANGELOG.md entry - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
