ocket8888 commented on code in PR #7454:
URL: https://github.com/apache/trafficcontrol/pull/7454#discussion_r1180666289
##########
experimental/traffic-portal/src/app/core/cache-groups/asns/detail/asn-detail.component.scss:
##########
@@ -12,15 +12,17 @@
* limitations under the License.
*/
-mat-card {
+.mat-mdc-card {
Review Comment:
according to [the Angular Material docs on
theming](https://material.angular.io/guide/theming#style-customization-outside-the-theming-system):
> Component DOM structure and CSS classes are considered private
implementation details that may change at any time.
The examples for this component do not include this class selector; it seems
totally undocumented. They also don't use `mat-card`, though. Instead they
always apply a class to the card and use the selector for that class. I'm not
sure how this internal refactor was applied throughout _our_ code, but I don't
think this change should be made.
##########
experimental/traffic-portal/src/app/core/cache-groups/coordinates/table/coordinates-table.component.spec.ts:
##########
@@ -13,7 +13,7 @@
*/
import { ComponentFixture, fakeAsync, TestBed, tick } from
"@angular/core/testing";
-import { MatDialog, MatDialogModule, type MatDialogRef } from
"@angular/material/dialog";
+import { MatDialog, MatDialogModule, MatDialogRef } from
"@angular/material/dialog";
Review Comment:
why? was this done automatically? I can't fathom why that would be.
##########
experimental/traffic-portal/src/app/shared/shared.module.ts:
##########
@@ -81,7 +81,8 @@ import { CustomvalidityDirective } from
"./validation/customvalidity.directive";
AppUIModule,
CommonModule,
RouterModule,
- MatMenuModule
+ MatMenuModule,
+ NgOptimizedImage
Review Comment:
this is imported in the root app module as well; does it need to be imported
in multiple places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
