jpappa200 commented on code in PR #7471:
URL: https://github.com/apache/trafficcontrol/pull/7471#discussion_r1181728445
##########
lib/go-atscfg/parentdotconfig.go:
##########
@@ -167,8 +167,9 @@ func MakeParentDotConfig(
// primarySecondary contains the names of the primary and secondary parent
cache groups.
type primarySecondary struct {
Review Comment:
Should we update the comment for this structure to include what nulls is
used for
##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -7759,7 +7759,6 @@ func TestMakeRemapDotConfigMidNoCacheRemapLineTopo(t
*testing.T) {
dsType := tc.DSType("HTTP_NO_CACHE")
- // BNO
Review Comment:
Random deletion, but looks like it needs to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
